Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcpcd: Update to v10.1.0 #4363

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

aquilapl
Copy link
Contributor

@aquilapl aquilapl commented Nov 15, 2024

Summary

No changelog available, here is the commit history

Test Plan

Checked for compatibility with existing dependencies and performed basic testing.

Checklist

  • Package was built and tested against unstable

@ReillyBrogan
Copy link
Contributor

Do you use this package by chance? We don't really use it for anything (NetworkManager has an internal DHCP client that we use) so I'm tempted to just remove it unless there's a legitimate need for it

@aquilapl
Copy link
Contributor Author

I am learning and took a package from https://shared.getsol.us/justin/updates/ that would not give me any difficulties. And the difference in the version was significant. I don't need it. I don't know what I could update, something that doesn't have a maintainer, and the System (users) need it. The main thing I'm worried about is whether I followed all the git commands, because I was doing it for the first time.

@malfisya
Copy link
Member

malfisya commented Nov 15, 2024

@aquilapl if you are learning our packaging or want to practice git, I would suggest doing ”Good First Issue" tasks would be a good start. I would recommend either changing homepages or adding monitoring.yml.

It is not that I am against you updating any packages (quite the opposite actually). Updating a package requires you to test the package itself, which sometimes not as simple as just building it. I would defer to @ReillyBrogan whether or not to accept this PR. Anyway, thank you for trying our packaging, cheers!

@malfisya
Copy link
Member

I will take this over

@malfisya malfisya changed the title Update package dhcpcd to version 10.1.0 dhcpcd: Update to v10.1.0 Nov 22, 2024
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfisya since you are taking over this PR, can you build and then include pspec changes so you are listed in the spec

**Summary**

No changelog available, here is the [commit history](NetworkConfiguration/dhcpcd@v9.3.4...v10.1.0)
@davidjharder davidjharder merged commit 6b88ab6 into getsolus:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants