Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages missing the homepage key #411

Open
davidjharder opened this issue Sep 29, 2023 · 5 comments
Open

Packages missing the homepage key #411

davidjharder opened this issue Sep 29, 2023 · 5 comments
Labels
Priority: High High priority Type: Chore Not a feature or a bug

Comments

@davidjharder
Copy link
Member

davidjharder commented Sep 29, 2023

Many Solus packages do not have a homepage key set in package.yml. See the full list yourself by installing the ripgrep package and running the following ripgrep (rg) command from the root of this repository:

rg --files-without-match "homepage" -g '*package.yml' | sort

Guidance on fixing

  • Refer to our help site if you are new to packaging and need to set up your system: https://help.getsol.us/docs/packaging/prepare-for-packaging
  • If a package doesn't have a homepage, use a portion of the source URL.
    • Example: The package zimg does not seem to have a dedicated homepage, so you would use https://github.com/sekrit-twc/zimg
  • homepage goes after source, see https://help.getsol.us/docs/packaging/package.yml. Some existing package.ymls will have homepage in other places; don't worry about that
  • After you have added a homepage, rebuild the package. This checks that the homepage was added correctly.
  • One Pull Request for each package
  • If you would like to fix many packages you can pick a letter and fix packages starting with that letter
  • For programming language modules (perl, python, etc), a webpage is preferred (e.g. https://metacpan.org/pod/Acme or https://pypi.org/project/sync/). If there is no webpage at all for the module, provide the most relevant information possible.

The List

@davidjharder davidjharder added the Type: Chore Not a feature or a bug label Sep 29, 2023
@github-project-automation github-project-automation bot moved this to Triage in Solus Sep 29, 2023
@davidjharder davidjharder moved this from Triage to Ready in Solus Sep 29, 2023
@EbonJaeger EbonJaeger pinned this issue Sep 29, 2023
@TraceyC77 TraceyC77 added the Good First Issue Issue that is good for someone new to the Solus project to try to tackle label Oct 1, 2023
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 2, 2023
## Summary
Bugfixes:
- The inclusion of "homepage" to package.yml  fixes  getsolus#411

## Test Plan

- Launched the application

## Checklist

- [] Package was built against unstable and tested against stable
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 2, 2023
Bugfixes:
- The inclusion of "homepage" to package.yml  fixes  getsolus#411

- Launched the application

- [] Package was built against unstable and tested against stable
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 2, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of getsolus#411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 2, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of getsolus#411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 3, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of getsolus#411
- New source because the old one is not online

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable
FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 3, 2023
**Summary**

- Inclusion of "homepage" to package.yml
- Part of getsolus#411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable
TraceyC77 pushed a commit that referenced this issue Oct 3, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of #411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable

Co-authored-by: FAb7D <[email protected]>
TraceyC77 pushed a commit that referenced this issue Oct 3, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of #411
- New source because the old one is not online

**Test Plan**

- Launched the hunspell -d it_IT on the terminal

**Checklist**

- [x] Package was built and tested against unstable

Co-authored-by: FAb7D <fifu7fi@___gmail.com>
davidjharder pushed a commit that referenced this issue Oct 4, 2023
**Summary**

- Inclusion of "homepage" to package.yml
- Part of #411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable

Co-authored-by: FAb7D <fifu7fi@___gmail.com>
@Achilleshiel
Copy link
Contributor

Achilleshiel commented Oct 4, 2023

For now I have 2 follow up questions.

  1. Do you really want to have 2300 PR?
  2. If packages do not have a homepage but they do have a mention on the cpan or pypi network. Should that count as a homepage?

@TraceyC77
Copy link
Contributor

  1. 2300 pull requests would be a good problem to have, in that we would have most or all of our packages updated. We don't expect to get that many at once, this will likely be a long term effort
  2. Good questions. Yes, language related packages that do not have a website can have a link to their package. If there is a webpage of some sort, we prefer that. For instance, perl modules can be found on metacpan.org. I'll update in the issue description

TraceyC77 pushed a commit that referenced this issue Oct 5, 2023
## Summary

Part of #411 

- Add homepage

## Checklist

- [ ] ~~Package was built and tested against unstable~~ No code was
changed.
@malfisya
Copy link
Member

malfisya commented Oct 6, 2023

After you have added a homepage, rebuild the package. This checks that the homepage was added correctly.

Is this enough? Or do i have to have test plan too? If so, I don't know how to test a library (eg: zziplib). I'm planning to help out with this, starting from letter "z". (I'm total newbie). Thank you

@TraceyC77
Copy link
Contributor

After you have added a homepage, rebuild the package. This checks that the homepage was added correctly.

Is this enough? Or do i have to have test plan too? If so, I don't know how to test a library (eg: zziplib). I'm planning to help out with this, starting from letter "z". (I'm total newbie). Thank you

Thanks for helping us with these homepages.

I would say the test plan can just be something like "verified the added homepage loads information about the package". You don't need to test the library or package itself, since you're not changing anything but the homepage information. This doesn't change how the software behaves.

Let us know if you have any other questions.

FAb7D pushed a commit to FAb7D/packages that referenced this issue Oct 7, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of getsolus#411

**Test Plan**

- Launched the application on terminal

**Checklist**

- [x] Package was built and tested against unstable
FriesischScott pushed a commit to FriesischScott/packages that referenced this issue Oct 7, 2023
**Summary**

- The inclusion of "homepage" to package.yml
- Part of getsolus#411

**Test Plan**

- Launched the application on terminal

**Checklist**

- [x] Package was built and tested against unstable
malfisya added a commit to malfisya/packages that referenced this issue Oct 9, 2023
**Summary**

- Adding `homepage` key to `package.yml`
- Part of getsolus#411

**Test Plan**

- Build the package
- Build successful

**Checklist**

- [x] Package was built against unstable
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Add homepage key to package.yml (Part of getsolus#411)
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Update to 0.7.2 [changelog](https://sigrok.org/gitweb/?p=sigrok-cli.git;a=log;h=refs/tags/sigrok-cli-0.7.2)
- Add homepage key to package.yml (Part of getsolus#411)
- Fixes [getsolus#2888](getsolus#2888)
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
 - Add homepage to package.yml (Part of getsolus#411)
 - Add additional patch to properly include python3-embed
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Add homepage key to package.yml (Part of getsolus#411)
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Update to 0.7.2 [changelog](https://sigrok.org/gitweb/?p=sigrok-cli.git;a=log;h=refs/tags/sigrok-cli-0.7.2)
- Add homepage key to package.yml (Part of getsolus#411)
- Fixes [getsolus#2888](getsolus#2888)
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Update to 0.7.2 [changelog](https://sigrok.org/gitweb/?p=sigrok-cli.git;a=log;h=refs/tags/sigrok-cli-0.7.2)
- Add homepage key to package.yml (Part of getsolus#411)
- Fixes [getsolus#2888]
A108384 added a commit to A108384/packages that referenced this issue Aug 28, 2024
**Summary**
- Update to 0.7.2 [changelog](https://sigrok.org/gitweb/?p=sigrok-cli.git;a=log;h=refs/tags/sigrok-cli-0.7.2)
- Add homepage key to package.yml (Part of getsolus#411)
- Fixes (getsolus#2888)
malfisya pushed a commit that referenced this issue Oct 1, 2024
The workaround is to set CC=gcc in the environment when running the
configure script. This bypasses a wonky internal configure function that
makes the configure script fail otherwise. Also add homepage.

Fixes #3853

Closes #3554 (the last does not build package in the list).

Part of #411

Signed-off-by: Rune Morling <[email protected]>
hosttry added a commit to hosttry/packages that referenced this issue Oct 7, 2024
Add homepage key as the package does not have it.
See: getsolus#411
malfisya added a commit that referenced this issue Nov 5, 2024
**Summary**

Add `homepage` key to `package.yml` (Part of #411)
@malfisya malfisya unpinned this issue Nov 7, 2024
@malfisya malfisya added Priority: High High priority and removed Good First Issue Issue that is good for someone new to the Solus project to try to tackle labels Nov 7, 2024
malfisya added a commit that referenced this issue Nov 13, 2024
**Summary**

- Fix build (Resolves #3155)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 13, 2024
**Summary**

- Fix build (Resolves #3155)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
androidnisse added a commit to androidnisse/packages that referenced this issue Nov 13, 2024
**Summary**
- Resolves getsolus#3856
- Part of getsolus#411
@androidnisse androidnisse mentioned this issue Nov 13, 2024
1 task
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
**Summary**

- Fix build (Resolves getsolus#3155)
- Add `homepage` key to `package.yml` (Part of getsolus#411)
- Add monitoring.yml (Part of getsolus#4121)
davidjharder pushed a commit to androidnisse/packages that referenced this issue Nov 16, 2024
**Summary**
- Resolves getsolus#3856
- Part of getsolus#411
davidjharder pushed a commit to androidnisse/packages that referenced this issue Nov 16, 2024
**Summary**
- Resolves getsolus#3856
- Part of getsolus#411
malfisya added a commit that referenced this issue Nov 24, 2024
**Summary**

- Fix build (Resolves #2225)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 24, 2024
**Summary**

- Fix build
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High High priority Type: Chore Not a feature or a bug
Projects
Status: Ready
Development

No branches or pull requests

4 participants