Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Disable tracing for generic redirects in web frameworks #48

Open
2 tasks
jjbayer opened this issue Jan 25, 2024 · 0 comments
Open
2 tasks

Chore: Disable tracing for generic redirects in web frameworks #48

jjbayer opened this issue Jan 25, 2024 · 0 comments
Milestone

Comments

@jjbayer
Copy link
Member

jjbayer commented Jan 25, 2024

As discussed in Client Infra TSC:

We noticed that our own Django project appends a trailing slash to any route, even if the route is unknown, and that the Django integration creates a transaction for such requests with a "transaction" set to the raw URL path. This leads to noise in the product and high cardinality in our transaction metrics storage:

image

Similar to generic 404s, we should not create a transaction for this type of generic redirect in any web framework, at least not by default. If we want to offer the user an opt-in for these transactions, we should name them "transaction": "redirect" or similar to reduce noise.

Note that this is not about all redirects (e.g. custom endpoints that run business logic before responding with 301), but rather about generic redirects that are cheap for the server, e.g. URL normalization (like appending a trailing slash).

Tasks

jjbayer added a commit to getsentry/sentry that referenced this issue Feb 9, 2024
Discard generic redirects in `before_send_transaction` until
getsentry/team-sdks#48 is done.
@stephanie-anderson stephanie-anderson added this to the [1] Discovery milestone Jul 4, 2024
@stephanie-anderson stephanie-anderson changed the title Disable tracing for generic redirects in web frameworks Chore: Disable tracing for generic redirects in web frameworks Jul 4, 2024
@stephanie-anderson stephanie-anderson modified the milestones: [1] Discovery, [5] On Hold, Tracing Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants