Project: Filter emails in URLs correctly

[kahest]

Description

URLs sent to Sentry should have authority filtered correctly. While this is implemented already, filtering of emails from other parts of the URL is not desired. This has come up in the following issues:
getsentry/sentry-java#2690
getsentry/sentry-dart#1418

The goal of this issue is to ensure that all our SDKs

1. filter authority correctly
2. don't filter email from other parts of the URL

Examples: (for more see e.g. https://github.com/getsentry/sentry-dart/blob/8a10ab719072f65d029985c211471d779ab2a3cb/dart/test/utils/http_sanitizer_test.dart#L9)

Input	Expected
https://dev.sentry.io/api/v4/reset/[email protected]	https://dev.sentry.io/api/v4/reset/[email protected]
https://user:[email protected]?q=1&s=2&token=secret	https://[Filtered]:[Filtered]@sentry.io

Tasks

Beta Give feedback

1. Filter emails in URLs correctly sentry-cocoa#3417
   Platform: Cocoa +1
2. Correctly filter URL with an email address in it sentry-java#2690
   Platform: Android Platform: Java Type: Bug +3
3. React Native
4. Correctly filter URL with an email address in it sentry-dart#1418
   Effort: Small Impact: Large Platform: Dart bug +4
   

[krystofwoldrich]

React Native uses sanitization logic from JS which passes the test correctly https://github.com/getsentry/sentry-javascript/blob/08308664394fb9eabda9f334f4cf97048fa0a4d9/packages/utils/test/url.test.ts#L72

https://github.com/getsentry/sentry-javascript/blob/08308664394fb9eabda9f334f4cf97048fa0a4d9/packages/node/test/integrations/http.test.ts#L321

[kahest]

React Native uses sanitization logic from JS which passes the test correctly getsentry/sentry-javascript@0830866/packages/utils/test/url.test.ts#L72

getsentry/sentry-javascript@0830866/packages/node/test/integrations/http.test.ts#L321

Thanks for checking! I don't see a test for the first case though - with email outside of the authority part, e.g. https://dev.sentry.io/api/v4/reset/[email protected] -> https://dev.sentry.io/api/v4/reset/[email protected]