-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network connection change breadcrumbs #82
Comments
Android can collect all this info through a system API |
For .NET MAUI, we already implemented a network status listener, for the purpose of pausing trying to push events to Sentry when the device has already made it clear that it's offline. Events are added to cache until the listener says its back online. We could easily add a breadcrumb whenever the status changes. It would need only a small amount of refactoring. We leverage MAUI's On Android, this requires the app have the |
Regarding Flutter: Is there already a specification for those breadcrumbs? Edit: I've published a package which does it at https://pub.dev/packages/sentry_connectivity |
RN Doesn't have API to collect this information, but since it will be in the native breadcrumbs it will be automatically part of RN event crumbs. |
Implementing this in getsentry/sentry-cocoa#3232. There, I called the breadcrumb type I had considered just using |
I just updated the description. On Android the breadcrumbs have: I'm not sure if develop docs are to be updated, as these really affect only mobile SDKs, but perhaps it's a good idea anyway, since i didn't find the |
@krystofwoldrich we have this on iOS/Android - does this already work on RN or do we need to add some glue code? |
^ Update - needs testing and exposing the option in the RN options |
RN breadcrumbs have this from the native SDKs breadcrumbs. Users can disable these but can filter them out in beforeSend. iOS since https://github.com/getsentry/sentry-react-native/releases/tag/5.11.0 Currently, we don't allow any granular setting of what breadcrumbs are added from native. It's all native and filter or no native. |
In order to provide more information, Sentry could collect another type of breadcrumbs: network breadcrumbs.
This would be important especially for mobile or desktop SDKs.
The idea to collect data on every network changes:
Network details include:
The goal of this issue is just to understand what platforms can gather these information, so that we can build something that will be used by all the mobile SDKs
The breadcrumbs have:
type:
system
category:
network.event
data["action"]
: one ofNETWORK_AVAILABLE
,NETWORK_LOST
,NETWORK_CAPABILITIES_CHANGED
Platforms
The text was updated successfully, but these errors were encountered: