feat(dashboards): Add incomplete bucket support to LineChartWidget
#81405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
edwardgou-sentry
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly adapted from #72469, with some minor changes to the code. In short, given a data delay of about 90s, any chart buckets that fall into that delay are plotted with a dotted line.
Right now this is done using a series of crimes, in which we split the series into two: a complete and an incomplete. A future version of ECharts promised to allow styling line segments of a series, but right now that's not possible. Even using a custom renderer doesn't work because in that case the segments are plotted one-by-one, which creates a "broken" line, without proper caps.
e.g.,
