Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): broken screen rendering doc link #81257

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

DominikB2014
Copy link
Contributor

  1. Update the screen rendering module doc link and module description. Previous it was set as TODO, and now we have the correct link
  2. Update all other module doc links to match our domain view docs, we did have redirects so this wasn't broken, but it's always better to not rely on redirects if possible. So might as well update them to be the correct url

@DominikB2014 DominikB2014 requested a review from a team as a code owner November 25, 2024 18:48
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2024
@DominikB2014 DominikB2014 requested a review from a team November 27, 2024 21:12
static/app/views/insights/mobile/screens/settings.ts Outdated Show resolved Hide resolved
static/app/views/insights/mobile/ui/settings.ts Outdated Show resolved Hide resolved
DominikB2014 and others added 2 commits November 27, 2024 16:53
Co-authored-by: Nar Saynorath <[email protected]>
Co-authored-by: Nar Saynorath <[email protected]>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81257      +/-   ##
==========================================
+ Coverage   80.34%   80.36%   +0.01%     
==========================================
  Files        7221     7232      +11     
  Lines      319562   319726     +164     
  Branches    20782    20806      +24     
==========================================
+ Hits       256752   256939     +187     
+ Misses      62416    62394      -22     
+ Partials      394      393       -1     

@DominikB2014 DominikB2014 merged commit efe28a9 into master Nov 27, 2024
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/update-docs-link branch November 27, 2024 22:06
jan-auer added a commit that referenced this pull request Nov 28, 2024
* master: (219 commits)
  fix: flatten searchable os distribution fields (#81297)
  chore(profiling): Remvoe unused profile functions metrics hook (#81396)
  fix(prompts): Properly return false instead of undefined when prompt data is null (#81404)
  fix(insights): broken screen rendering doc link (#81257)
  fix(rpc): Only groupby when needed (#81403)
  feat(grouping): Tally frame types while building exception grouping components (#81341)
  fix(similarity): Limit > 30 system frame check to Java (#81385)
  feat(alerts): Adds EAP spans results consumer configs (#81365)
  ref(insights): simplify domain view header by using tab links (#81324)
  fix(issues): Add projectId for flag onboarding on click (#81387)
  chore(flamegraphs): Remove unused legacy flamegraph code path (#81381)
  fix(performance): No table overflow + glitchy behaviour (#81378)
  feat(widget-builder): Add feature flag for redesign (#81377)
  feat(profiling): Clean up continuous profiling ui and compat flags (#81260)
  feat(visibility): Clamp date range for `TagStore` queries (#81363)
  test(taskbroker): Add CLI command for sending taskbroker tasks (#81319)
  feat(dashboards): Add ff for favouriting dashboards (#81368)
  fix(trace) match event_id by error (#81370)
  fix(insights): add missing slash on performance moving banner (#81364)
  ref(models): Include event id in `Event` repr (#81345)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants