Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Add top events support #81217

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wmak
Copy link
Member

@wmak wmak commented Nov 22, 2024

  • This allows the usage of top_events with the useRpc param
  • TODO: going to add proper SearchResolver column caching, its being called quite heavily by these changes
  • TODO: going to follow up with more rigorous testing

- This allows the usage of top_events with the useRpc param
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/search/eap/spans.py 77.77% 4 Missing ⚠️
src/sentry/snuba/spans_rpc.py 98.46% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #81217       +/-   ##
===========================================
+ Coverage   58.28%   80.34%   +22.06%     
===========================================
  Files        7203     7215       +12     
  Lines      318916   319529      +613     
  Branches    20776    20776               
===========================================
+ Hits       185885   256732    +70847     
+ Misses     132637    62403    -70234     
  Partials      394      394               

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant