Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flamegraph): Remove unused expand toggle on aggregate flamegraph #80191

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Nov 4, 2024

This toggle doesn't do anything right now. Comment it out as it may be used to render a list of examples later.

This toggle doesn't do anything right now. Comment it out as it may be used to
render a list of examples later.
@Zylphrex Zylphrex requested a review from a team as a code owner November 4, 2024 16:01
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8153 1 8152 0
View the top 1 failed tests by shortest run time
WidgetBuilder with events > Sort by selectors can update selectors values
Stack Traces | 1.04s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 2
Received array:  [<span data-test-id="label">count()</span>, <div class="css-1h9r4of-SingleValueLabel-overflowEllipsis e1qwfwjv0">count()</div>]
    at Object.<anonymous> (.../dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx:313:67)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processTimers (node:internal/timers:511:9)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Zylphrex Zylphrex merged commit 0fd4b33 into master Nov 4, 2024
44 checks passed
@Zylphrex Zylphrex deleted the txiao/chore/remove-unused-expand-toggle-on-aggregate-flamegraph branch November 4, 2024 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants