feat(billing): Invite billing members to a developer plan #80129
Conversation
github-actions
bot
added
the
Scope: Frontend
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80129 +/- ##
==========================================
+ Coverage 78.48% 80.34% +1.85%
==========================================
Files 7209 7216 +7
Lines 319472 319491 +19
Branches 43975 20780 -23195
==========================================
+ Hits 250732 256689 +5957
- Misses 62340 62408 +68
+ Partials 6400 394 -6006 |
jarrettscott
changed the title
Bundle ReportChanges will increase total bundle size by 93.46kB (0.29%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
src/sentry/conf/server.py
Outdated
| "scopes": {"org:billing"}, | ||
| "is_team_roles_allowed": False, | ||
| "is_retired": False, | ||
| }, |
There was a problem hiding this comment.
Adding this role will expose this for the self-hosted open source instances of Sentry.
There was a problem hiding this comment.
Removed the billing role in dc79aba. The role was being used for validation purposes. The refactored validation logic will inspect the feature flags and determine if a bypass is needed.
|
|
||
| if assigned_org_role != "billing" and not features.has( | ||
| "organizations:invite-members", organization, actor=request.user | ||
| ): |
There was a problem hiding this comment.
Inviting billing members would be equivalent to inviting owners on the developer plan.
I wasn't able to invite another owner on the developer plan, so that would also need to change to match the behaviour:
Description
Allow Billing members to be added to Developer plans.
Introduces a new variable,
isOverMemberLimit, which mimics the getsentry calculation. When the member limit is reached, the only available role for new member invitations will be the Billing role. The role and team dropdown menus will be disabled. Additional UI elements are also disabled.NOTE: This ability will be hidden behind a feature flag. When an org reaches the member limit, they must request permission before they will be allowed to add a billing member.