feat(ds): Detect health check routes with trailing slash #81117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
loewenheim
approved these changes
Nov 21, 2024
Dav1dde
approved these changes
Nov 21, 2024
Comment on lines
+793
to
+805
| # Same as above with trailing slash. Relay's pattern matcher cannot handle | ||
| # optional trailing slashes. | ||
| "*/health/", | ||
| "*/healthy/", | ||
| "*/healthz/", | ||
| "*/_health/", | ||
| r"*/\[_health\]/", | ||
| "*/live/", | ||
| "*/livez/", | ||
| "*/ready/", | ||
| "*/readyz/", | ||
| "*/ping/", | ||
| "*/up/", |
There was a problem hiding this comment.
Should we do this in Code instead? Automatically duplicate all entries with a slash?
There was a problem hiding this comment.
Will wait for getsentry/relay#4277 instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81117 +/- ##
==========================================
- Coverage 78.49% 78.48% -0.02%
==========================================
Files 7215 7215
Lines 319812 319811 -1
Branches 44045 44046 +1
==========================================
- Hits 251040 251000 -40
- Misses 62387 62412 +25
- Partials 6385 6399 +14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect health check routes with an without a trailing slash. Relay's pattern
matcher currently doesn't match groups with empty alternates (
*/ping{,/}), sowe duplicate all rules. On the upside, this leaves the pattern matcher in an
efficient postfix match.
Fixes #81028