Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for async-http #2427

Open
ScotterC opened this issue Oct 10, 2024 · 1 comment
Open

Patch for async-http #2427

ScotterC opened this issue Oct 10, 2024 · 1 comment
Assignees

Comments

@ScotterC
Copy link

Describe the idea
Sentry comes bundled with getting performance spans for Net::Http and a patch for Faraday is easy to enable. Are there any plans for an async-http? Ruby async is now built into ruby and is becoming much more common place for concurrent IO operations like external API requests.

Why do you think it's beneficial to most of the users
When understanding performance issues, external http calls can be a big hit. Currently if using async-http these show up as "Missing Instrumentation" in Sentry. Also, when improving IO performance, moving calls to asynchronous calls is a common tool applied which one would want to see reflected in Sentry perf dashboards.

Possible implementation

@redterror
Copy link

Ruby async is now built into ruby and is becoming much more common place for concurrent IO operations like external API requests.

Piling onto the sentiment here, Rails in 7.1 has a new async api for database operations (e.g. load_async and friends). I came across this issue digging into the 'Missing instrumentation' output in that context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants