Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Hackney to Finch as the default HTTP client #724

Open
whatyouhide opened this issue Apr 21, 2024 · 4 comments · May be fixed by #758
Open

Switch from Hackney to Finch as the default HTTP client #724

whatyouhide opened this issue Apr 21, 2024 · 4 comments · May be fixed by #758
Assignees
Milestone

Comments

@whatyouhide
Copy link
Collaborator

Finch is really reliable and fast, and has significantly less dependencies than Hackney. It also exposes Telemetry events, whereas Hackney doesn't.

I think it would be nice to switch to it as the default client. We can leave Sentry.HackneyClient around for people that prefer it.

Thoughts @sl0thentr0py?

@sl0thentr0py
Copy link
Member

yep sure if you think that's better, go for it!

@whatyouhide whatyouhide self-assigned this Apr 23, 2024
@savhappy savhappy self-assigned this Jul 2, 2024
@savhappy
Copy link
Collaborator

savhappy commented Jul 6, 2024

@whatyouhide should we have a flag that can be flipped to use Hackney instead of Finch after Finch is set as default? And apply this flag to the supervision tree upon start?

@whatyouhide
Copy link
Collaborator Author

No it's not necessary. We can just switch to Finch. If users want to use Hackney, they can write an adapter—maybe we can just put the Hackney Sentry client we have now in the codebase over into the docs if they want to copypaste that.

@savhappy
Copy link
Collaborator

PR out for this switch-a-roo @whatyouhide ^_^

@savhappy savhappy linked a pull request Aug 5, 2024 that will close this issue
@whatyouhide whatyouhide added this to the 11.0.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants