Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support performance/APM features #426

Closed
anthonator opened this issue Sep 2, 2020 · 18 comments
Closed

Support performance/APM features #426

anthonator opened this issue Sep 2, 2020 · 18 comments

Comments

@anthonator
Copy link

Does this project plan to add support for Sentry's performance/APM features? Elixir's/Erlang's telemetry support seems like a perfect fit for this.

@mitchellhenke
Copy link
Contributor

It’s something I’ve definitely been keeping an eye on. Now that it’s released, I’ll be trying to get some proofs of concept together.

@anthonator
Copy link
Author

Is there anything the community can do to help?

@mitchellhenke
Copy link
Contributor

Good question, thanks for asking it!

Once I have a better handle on the structure, I’ll create issues around the features which should be a great place for contributions 🙂

@mitchellhenke
Copy link
Contributor

It turns out that before this can happen I will need to make some bigger changes to move existing functionality to the new Unified API and Envelope data format, so I'll be tackling that first.

@anthonator
Copy link
Author

I wonder if a good MVP would be just to have the ability to send metrics to Sentry. We can manually hook up telemetry since Phoenix, Ecto, etc. have good telemetry support.

@UnderFenex
Copy link

Waiting for this feature :)

@mitchellhenke
Copy link
Contributor

It's an exciting feature that's at the top of my list for support!

Ruby's conversion to the Unified API and Envelope format gives a bit of an insight into what needs to happen first: https://github.com/getsentry/sentry-ruby/projects/3

This library's footprint is smaller, so it should be easier in some respects 🙂

@hauleth
Copy link
Contributor

hauleth commented Dec 16, 2020

Is there API specification for that? I could review the possibility to implement such feature if only there is stable API for that. I could make it a backend for Erlang's OpenTelemetry implementation.

@mitchellhenke
Copy link
Contributor

Apologies this is taking longer than anticipated, but I'm hoping that the holidays will give me some time to finish the partial implementation I have.

@hauleth It's sort of spread across a handful of pages: https://develop.sentry.dev/sdk/event-payloads/transaction/, https://develop.sentry.dev/sdk/event-payloads/span/ have some description, but I'd be very interested in making it easier to integrate with OpenTelemetry.

@speeddragon
Copy link

speeddragon commented Feb 6, 2021

Is the APM feature available for free accounts? I don't mind to help to implement this feature, I will try to check the API.

@mitchellhenke
Copy link
Contributor

@speeddragon I'm not sure, I'd reach out to Sentry to see.

I've been making slow progress, but not as much as I'd like 🙂

@speeddragon
Copy link

speeddragon commented Feb 6, 2021

I'm trying to understand the request that needs to be made, I can make a successful request, but nothing appears on the Performance tab. I've testes with a JavaScript project and it works, I need to check what is missing in my HTTP request. If I make some progress I will reply back.

EDIT: Finally made a successful request via Postman. I will try to integrate that with this repo.

@tsloughter
Copy link

Sentry is adopting OpenTelemetry in general, right? It doesn't cover all Sentry features at this time but starting with tracing and using the OpenTelemetry Erlang/Elixir lib for this would mean many more people involved in helping move it forward and a shared base.

You, or anyone reading this interested in these Sentry features for Elixir, should check out the Observability Working Group of the Erlang Ecosystem Foundation https://erlef.org/wg/observability and the Erlang/Elixir OpenTelemetry SIG https://github.com/open-telemetry/community#special-interest-groups

@eprothro
Copy link

Is there any update on support for tracing?

We're wanting to migrate from NewRelic to Sentry, and in our POC, we see the Sentry-Trace header make it from our front end Next.js project to our back-end elixir/absinthe project, but these error transactions aren't related on the Sentry Server side :/.

@ananthakumaran
Copy link

We are currently using Sentry for distributed tracing, and it works reasonably well with some caveats. The details of the setup can be found in the blog post.

@tsloughter
Copy link

@ananthakumaran nice. If you want it'd be great to get the propagator added to https://github.com/open-telemetry/opentelemetry-erlang-contrib/

@mikeover
Copy link

mikeover commented Jun 6, 2023

any updates on this @mitchellhenke ?

@whatyouhide whatyouhide added this to the 10.0.0 milestone Sep 22, 2023
@whatyouhide whatyouhide modified the milestones: 10.0.0, 11.0.0 Nov 23, 2023
@whatyouhide
Copy link
Collaborator

Closing this in favor of a single issue about APM, that is, #538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants