-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read debug IDs from debugId field in sourcemaps #2220
Comments
loewenheim
added a commit
that referenced
this issue
Nov 7, 2024
The main effect of and reason for this is that debug IDs in sourcemaps can now be read from the `"debugId"` field in addition to `"debug_id"`. Implements #2220.
loewenheim
added a commit
that referenced
this issue
Nov 7, 2024
This is accomplished by updating `symbolic` and `rust-sourcemap`. See getsentry/symbolic#874 and getsentry/rust-sourcemap#97. Closes #2220.
I think this may possibly have introduced a problem. On the latest @sentry/react-native 6.3.0 and @sentry/cli 2.39.0 android builds fail due to "bad json: duplicate field 'debug_id'"
|
+1 |
Hi, sorry for the inconvenience. This is fixed in https://github.com/getsentry/sentry-cli/releases/tag/2.39.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When uploading sourcemaps using
sentry-cli
, debug IDs should be read from the"debugId"
field as well as the current"debug_id"
.The TC39 proposal is for
"debugId"
to become the actual name, see https://github.com/tc39/source-map/blob/8be0fe10ad042e13f4196d17b44ddedfd6a9df58/proposals/debug-id.md?plain=1#L100-L117. For now we can support it in addition to"debug_id"
.This requires updates in
symbolic
andrust-sourcemap
:Once those are merged and released, a dependency update is all that's required.
debugId
field in sourcemaps #2222The text was updated successfully, but these errors were encountered: