Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference to jquery.mobile.custom.min.js in gumby.min.js #663

Open
wayout84 opened this issue Nov 18, 2019 · 4 comments
Open

reference to jquery.mobile.custom.min.js in gumby.min.js #663

wayout84 opened this issue Nov 18, 2019 · 4 comments

Comments

@wayout84
Copy link

Hi,

I notice a reference to jquery.mobile.custom.min.js in gumby.min.js that doesn't work.

To verify the problem I tried with mobile visualization in chrome and firefox. The problem shows itself on pages and categories pages.

The fix (for me) is to change the reference in: /theme/js/libs/jquery.mobile.custom.min.js

@ivanhercaz
Copy link
Contributor

@wayout84, in which theme are you getting this problem?

@wayout84
Copy link
Author

wayout84 commented Dec 12, 2019 via email

@ivanhercaz
Copy link
Contributor

I reproduced the error you reported. But I received it in all the website, I mean not only in pages and categories. The problem is in the minified version of gumby.min.js but it should be fixed too in gumby.init.js. I will propose a change to fix it.

Sorry, it's the first time I use github

Don't worry! We all had our first time, good luck!

ivanhercaz added a commit to ivanhercaz/pelican-themes that referenced this issue Dec 12, 2019
In getpelican#663 the user @wayout84 report an error caused by a bad reference to this jQuery library. I have fixed gumby.init.js and gumby.min.js to make it work although Pelican and console still reports that one file is missing (see the mentioned issue).
ivanhercaz added a commit to ivanhercaz/pelican-themes that referenced this issue Dec 12, 2019
In getpelican#663 the user @wayout84 report an error caused by a bad reference to this jQuery library. I have fixed gumby.init.js and gumby.min.js to make it work although Pelican and console still reports that one file is missing (see the mentioned issue).
ivanhercaz added a commit to ivanhercaz/pelican-themes that referenced this issue Dec 12, 2019
In getpelican#663 the user @wayout84 report an error caused by a bad reference to this jQuery library. I have fixed gumby.init.js and gumby.min.js to make it work although Pelican and console still reports that one file is missing (see the mentioned issue).
ivanhercaz added a commit to ivanhercaz/pelican-themes that referenced this issue Dec 12, 2019
In getpelican#663 the user @wayout84 report an error caused by a bad reference to this jQuery library. I have fixed gumby.init.js and gumby.min.js to make it work.
@ivanhercaz
Copy link
Contributor

ivanhercaz commented Dec 12, 2019

@wayout84, I fixed the error in the template to avoid next users the same error. Excuse me for a lot of reference to this issue by dirty commits. I reset the head of my branch in my pelican-themes fork because I wrote a bad commit message. And I really don't understand why the last commit I made (the valid one) is unverified...

When @justinmayer or someone of the @getpelican team will accept and merge the PR, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants