Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker doesn't start when minio enabled #87

Closed
muratdacic opened this issue Oct 19, 2024 · 5 comments
Closed

Worker doesn't start when minio enabled #87

muratdacic opened this issue Oct 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@muratdacic
Copy link

When minio enabled, worker is searching for non existing pvc, because there is a missing condition.
Line 179 and 185 in worker-deployment.yaml, instead of

{{ if not .Values.global.s3.enabled }}

can someone just put

{{- if and (not .Values.global.s3.enabled) (not .Values.minio.enabled) }}

@grthr
Copy link

grthr commented Oct 22, 2024

Same issue here: The PVC is still referenced in the lago-worker.

And there is no s3/minio configuration in lago-worker when minio is enabled.

@jdenquin jdenquin added the bug Something isn't working label Oct 22, 2024
@electrosenpai
Copy link
Contributor

electrosenpai commented Oct 22, 2024

{{ if not .Values.global.s3.enabled }}

Good catch here sorry about that. PR is on the way

Should be good with #89 merge

@grthr
Copy link

grthr commented Oct 22, 2024

what about S3 credentials in worker-deployment if using minio? I would expect S3 environment variables in the worker-deployment just like in api-deployment (lines 148-209):

{{ if or .Values.global.s3.enabled .Values.minio.enabled }}

@electrosenpai
Copy link
Contributor

Correct @grthr PR is on the way

@electrosenpai
Copy link
Contributor

Its now merge & should be good. Feel free to re-open this issue if its doesn't solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants