From 147651b9d5b40d500b21dad0bc709d76830dc2d0 Mon Sep 17 00:00:00 2001 From: Kelly Phan Date: Thu, 9 Jan 2025 12:20:12 +0100 Subject: [PATCH] fix: product design review --- .../EditCustomerInvoiceCustomSectionsDialog.tsx | 17 ++++++++--------- .../invoices/PreviewCustomSectionDrawer.tsx | 6 ++++-- .../settings/Invoices/CreateCustomSection.tsx | 2 ++ translations/base.json | 5 +++-- 4 files changed, 17 insertions(+), 13 deletions(-) diff --git a/src/components/customers/EditCustomerInvoiceCustomSectionsDialog.tsx b/src/components/customers/EditCustomerInvoiceCustomSectionsDialog.tsx index 2cbcd6aa4..21576aba2 100644 --- a/src/components/customers/EditCustomerInvoiceCustomSectionsDialog.tsx +++ b/src/components/customers/EditCustomerInvoiceCustomSectionsDialog.tsx @@ -182,16 +182,15 @@ export const EditCustomerInvoiceCustomSectionsDialog = forwardRef< {formikProps.values.behavior === BehaviorType.CUSTOM_SECTIONS && ( !selected) - .map((section) => ({ - labelNode: section.name, - label: section.name, - description: section.code, - value: section.id, - })) ?? [] + data?.invoiceCustomSections?.collection.map((section) => ({ + labelNode: section.name, + label: section.name, + description: section.code, + value: section.id, + })) ?? [] } onChange={(section) => formikProps.setFieldValue( @@ -213,7 +212,7 @@ export const EditCustomerInvoiceCustomSectionsDialog = forwardRef< } placeholder={translate('text_1735223938916qvvv12r7je0')} PopperProps={{ displayInDialog: true }} - emptyText={translate('text_1735223938916tlygbi5v0nd')} + emptyText={translate('text_173642092241713ws50zg9v4')} /> )} (
- +
)} title={ @@ -75,7 +77,7 @@ export const PreviewCustomSectionDrawer = forwardRef
-
+
{hasLocalData && (
{localData?.displayName && ( diff --git a/src/pages/settings/Invoices/CreateCustomSection.tsx b/src/pages/settings/Invoices/CreateCustomSection.tsx index 315e40ed1..59764916d 100644 --- a/src/pages/settings/Invoices/CreateCustomSection.tsx +++ b/src/pages/settings/Invoices/CreateCustomSection.tsx @@ -131,6 +131,8 @@ const CreateInvoiceCustomSection = () => {