Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore cache keys that are not page ids #21

Closed
bnomei opened this issue Mar 8, 2023 · 1 comment
Closed

ignore cache keys that are not page ids #21

bnomei opened this issue Mar 8, 2023 · 1 comment

Comments

@bnomei
Copy link

bnomei commented Mar 8, 2023

if the page object here is null then return early. this allows other code to hijack the pages cache and add key-value that do not relate to a real page object. like sitemaps.
why hijack? so these cache values get flushed when the pages cache does.

$url = $page->url($key['language']);

@bnomei
Copy link
Author

bnomei commented Mar 8, 2023

oh my. duplicate of this. #20 (comment)

@distantnative distantnative closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants