Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons 9: Use view button from backend for Lab #6547

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 20, 2024

Description

Summary of changes

  • Cleaned up orphaned Vue components
  • Using PHP-backed view buttons for the Lab

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jul 20, 2024
@distantnative distantnative added this to the 5.0.0-alpha.2 milestone Jul 20, 2024
@distantnative distantnative self-assigned this Jul 20, 2024
@distantnative distantnative force-pushed the v5/buttons/9-lab-and-clean branch 2 times, most recently from c309938 to db6a75c Compare July 22, 2024 11:15
@distantnative distantnative force-pushed the v5/buttons/9-lab-and-clean branch from db6a75c to d87c48c Compare July 25, 2024 11:20
@distantnative distantnative marked this pull request as ready for review July 25, 2024 11:22
@bastianallgeier bastianallgeier merged commit a529e34 into v5/develop Jul 25, 2024
15 checks passed
@bastianallgeier bastianallgeier deleted the v5/buttons/9-lab-and-clean branch July 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants