Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons 7: Backend classes for core view buttons #6545

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Buttons 7: Backend classes for core view buttons #6545

merged 2 commits into from
Jul 24, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 20, 2024 •
edited
Loading

Description

Summary of changes

  • Added PHP classes for more complex core view buttons

Additional context

Currently unused, but will be connected to the actual backend-frontend exchange in a subsequent PR.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 20, 2024
@distantnative distantnative added this to the 5.0.0-alpha.2 milestone Jul 20, 2024
@distantnative distantnative self-assigned this Jul 20, 2024
@distantnative distantnative force-pushed the v5/buttons/7-core-view-button-classes branch from 48e6b42 to 36a39e8 Compare July 20, 2024 18:21
This was referenced Jul 20, 2024
Merged
Merged
@distantnative distantnative force-pushed the v5/buttons/7-core-view-button-classes branch from 36a39e8 to 25612d7 Compare July 22, 2024 10:26
@distantnative
Copy link
Member Author

Regarding code coverage: The tests actually fully cover the LanguagesButton class. But for whatever reason PHPUnit has a problem with the method name ::option() as it seems to me. When I change just the method name to ::optionn() it reports 100% coverage.

@distantnative distantnative force-pushed the v5/buttons/7-core-view-button-classes branch 2 times, most recently from 60fd7b9 to 11404fc Compare July 22, 2024 11:14
@bastianallgeier bastianallgeier force-pushed the v5/buttons/7-core-view-button-classes branch from 11404fc to 2fa9d0b Compare July 24, 2024 08:51
@distantnative distantnative marked this pull request as ready for review July 24, 2024 09:00
@distantnative distantnative requested a review from a team July 24, 2024 09:00
bastianallgeier
bastianallgeier approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely no idea why Codecov is acting up with the LanguagesButton::option method. Let's ignore it.

@bastianallgeier bastianallgeier merged commit 92ae143 into v5/develop Jul 24, 2024
10 of 11 checks passed
@bastianallgeier bastianallgeier deleted the v5/buttons/7-core-view-button-classes branch July 24, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
5.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier