Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons 4: View button PHP classes #6542

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Buttons 4: View button PHP classes #6542

merged 3 commits into from
Jul 24, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 20, 2024 •
edited
Loading

Description

Summary of changes

  • New Panel\Ui\Buttons\ViewButtons and Panel\Ui\Buttons\ViewButton classes
    • responsible for gathering and transforming view buttons configured in blueprints, config files and/or Panel areas
    • renders them as PHP array definitions that can be handed to the dedicated Vue frontend components
  • Added Panel\Model::model() method

Reasoning

  • Backend companions for k-view-button and k-view-buttons

Additional context

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 20, 2024
@distantnative distantnative added this to the 5.0.0-alpha.2 milestone Jul 20, 2024
@distantnative distantnative self-assigned this Jul 20, 2024
@distantnative distantnative force-pushed the v5/buttons/4-view-button-classes branch 3 times, most recently from d84de57 to 4e32e61 Compare July 20, 2024 17:03
@distantnative distantnative mentioned this pull request Jul 20, 2024
Merged
6 tasks
@distantnative distantnative force-pushed the v5/buttons/4-view-button-classes branch from 4e32e61 to 3023173 Compare July 20, 2024 18:19
This was referenced Jul 20, 2024
Merged
Merged
@distantnative distantnative force-pushed the v5/buttons/4-view-button-classes branch 2 times, most recently from 5838eef to 5c86a32 Compare July 22, 2024 09:42
@distantnative distantnative marked this pull request as ready for review July 22, 2024 09:48
@distantnative distantnative requested a review from a team July 22, 2024 09:48
@distantnative distantnative force-pushed the v5/buttons/4-view-button-classes branch from 76b1ab8 to e53459c Compare July 22, 2024 10:58
@distantnative distantnative force-pushed the v5/buttons/4-view-button-classes branch from e53459c to ec120df Compare July 22, 2024 11:14
@bastianallgeier bastianallgeier merged commit ea5bcb2 into v5/develop Jul 24, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/buttons/4-view-button-classes branch July 24, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
5.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier