Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue: don't use loop index for :key #6477

Closed
wants to merge 1 commit into from
Closed

Vue: don't use loop index for :key #6477

wants to merge 1 commit into from

Conversation

distantnative
Copy link
Member

Description

Summary of changes

  • Tries to replace using the loop index for :key with a stable value

Reasoning

  • Especially in Vue 3, it can trip up Vue quite a bit if the identifying key changes based on the position in the loop

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jun 9, 2024
@distantnative distantnative added this to the 5.0.0-alpha.2 milestone Jun 9, 2024
@distantnative distantnative self-assigned this Jun 9, 2024
@distantnative distantnative marked this pull request as ready for review June 9, 2024 08:13
@distantnative distantnative requested a review from a team June 9, 2024 08:13
@distantnative distantnative force-pushed the v5/refactor/vue-key-no-loop-index branch from 18bca90 to dbea517 Compare June 9, 2024 19:10
@distantnative distantnative removed the request for review from a team June 9, 2024 19:12
@distantnative distantnative marked this pull request as draft June 9, 2024 19:12
@distantnative distantnative force-pushed the v5/refactor/vue-key-no-loop-index branch 3 times, most recently from 2d0f038 to 92179ab Compare July 4, 2024 12:57
@distantnative distantnative force-pushed the v5/refactor/vue-key-no-loop-index branch from 92179ab to 969ad01 Compare July 4, 2024 12:58
@distantnative distantnative deleted the v5/refactor/vue-key-no-loop-index branch July 4, 2024 13:00
@distantnative distantnative removed this from the 5.0.0-alpha.3 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@distantnative