Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add basic + sync operation on information_schema, tested on … #57

Closed
wants to merge 0 commits into from
Closed

feature: add basic + sync operation on information_schema, tested on … #57

wants to merge 0 commits into from

Conversation

zqWu
Copy link
Contributor

@zqWu zqWu commented Mar 10, 2023

Description

  • add some schema operation. like show_database, show tables.
  • update macros/seeds.sql, now it works properly when tableexists
  • test cases (these test are not unit tests) :
    • default_catalog + seed as kafka ===> seed twice, data duplicate. we cannot drop kafka data by flink
    • hive catalog + minio ===> seed twice, one data
    • hive catalog + iceberg ===> seed twice, one data

Resolves #55

PR Checklist
  • Tests added. (not unit tests, dont know how to deal with these code )

@gliter
Copy link
Collaborator

gliter commented Mar 13, 2023

As for tests I still didnt found time to add test framework. What I have in mind are two types of tests:

  • mocked sql client so we can test all the macro generation and interaction with Flink sql gateway using that mock
  • end to end test with Flink and Kafka and maybe some DB running as containers in test.

@gliter
Copy link
Collaborator

gliter commented Mar 13, 2023

Could you please check MyPy failures?

@gliter
Copy link
Collaborator

gliter commented Mar 14, 2023

@zqWu you should be able to run all checks on your machine using pre-commit run -a

@zqWu zqWu marked this pull request as draft March 15, 2023 10:42
@zqWu zqWu closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt seed not works as expect
2 participants
@zqWu @gliter