Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: additional explainer for the pod-selector #4316

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mrsimonemms
Copy link
Contributor

Proposed change

Improves the documentation for the gethomepage.dev/pod-selector annotation on the automatic service discovery page. There's at least two discussions about this resulting in NOT FOUND on the service health icon, so this explains why that's happening and how to fix it.

Discussions:

Closes # (issue)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@mrsimonemms mrsimonemms marked this pull request as ready for review November 21, 2024 16:38
docs/configs/kubernetes.md Outdated Show resolved Hide resolved
@shamoon shamoon enabled auto-merge (squash) November 21, 2024 16:43
auto-merge was automatically disabled November 22, 2024 15:28

Head branch was pushed to by a user without write access

@mrsimonemms
Copy link
Contributor Author

Thanks @shamoon, hopefully this is closer to what you'd like to see.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great thanks!

@shamoon shamoon changed the title Docs: additional explainer for the pod-selector Documentation: additional explainer for the pod-selector Nov 22, 2024
@shamoon shamoon merged commit 5697253 into gethomepage:dev Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants