Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does this theme work with php 8.3 and gravcms 1.7.46 #17

Open
joebordes opened this issue Jun 6, 2024 · 5 comments
Open

does this theme work with php 8.3 and gravcms 1.7.46 #17

joebordes opened this issue Jun 6, 2024 · 5 comments

Comments

@joebordes
Copy link

I updated PHP 8.3 and gravcms 1.7.46. The site is giving two errors

waypoints.js jquery error which I fixed by updating waypoints to the latest version

jquery.3-x TypeError: url.indexOf is not a function
at jQuery.fn.load (jquery-3.x.min.js:10194:13)
at main.js:12:14
at main.js:247:3

I tried updating jquery also but the error just switches lines

any help appreciated

@joebordes joebordes changed the title does this theme work with php 8.3 does this theme work with php 8.3 and gravcms 1.7.46 Jun 6, 2024
@joebordes
Copy link
Author

I added this code:

jquery-3.x.js  line 10190
/**
 * Load a url into a page
 */
jQuery.fn.load = function( url, params, callback ) {
+	if (typeof url=='function') {
+		return url();
+	}
	var selector, type, response,
		self = this,
		off = url.indexOf( " " );

and the page loads now, the HTML is messed up, due to the twig raw change
HTH

@joebordes
Copy link
Author

TypeError: sections.waypoint is not a function
    at main.js:94:11
    at main.js:247:3

@joebordes
Copy link
Author

can't get imagelightbox working :-/

@robertgarrigos
Copy link

this PR fixes this.

@joebordes
Copy link
Author

Thanks! I'll give it a try when I can and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants