Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular nav doesn't work when title is changed #8

Open
olivierdalang opened this issue Feb 23, 2017 · 0 comments
Open

Modular nav doesn't work when title is changed #8

olivierdalang opened this issue Feb 23, 2017 · 0 comments

Comments

@olivierdalang
Copy link

Hi !

It seems the modular templates hardcode section ids while the nav generates links using the page title.
This means the one page navigation breaks when page menu string is not the same than the hardcoded id.

In templates/modulars/news.html.twig :

<section id="news" class="section-news">

In intemplates/partials/navigation.html.twig` :

<a class="nav-link" href="#{{ _self.pageLinkName(module.menu) }}">{{ module.menu }}</a>
olivierdalang added a commit to olivierdalang/grav-theme-landio that referenced this issue Feb 23, 2017
@olivierdalang olivierdalang mentioned this issue Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant