Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YT Time Codes not working #32

Open
aaronxn opened this issue Mar 11, 2020 · 8 comments
Open

YT Time Codes not working #32

aaronxn opened this issue Mar 11, 2020 · 8 comments
Labels

Comments

@aaronxn
Copy link

aaronxn commented Mar 11, 2020

This works:
[plugin:youtube](https://youtu.be/c_8dnCiztcY)

This does not work:
[plugin:youtube](https://youtu.be/c_8dnCiztcY?t=543)

@rhukster
Copy link
Member

ah probably tripping up the regex.

@rhukster rhukster added the bug label Mar 11, 2020
@igniz-
Copy link

igniz- commented Apr 6, 2021

I think this is caused because when you embed the video, youtube expects start= instead of t= although setting it in the plugin address doesn't seem to work

@utagawal
Copy link

Any plans to get it fixed ?

@rhukster
Copy link
Member

Someone could create a pull request.

@utagawal
Copy link

Got the regex updated with :
?(?:&t=(\d+))?

but it doesn't help... in the embedd it sdhould pass on the start argument, butI cannot make it work...

@TheDancingCode
Copy link
Contributor

@rhukster
Are you opposed to switching from a regexp-based logic to parse_url for this plugin? It would allow for timestamps and playlists as requested in #28. I could rewrite the plugin a bit.

@utagawal
Copy link

@TheDancingCode can you move forward with a fork maybe, I really need to publish an article with this functionality working. Thxxxxx

@igniz-
Copy link

igniz- commented Jun 29, 2021

@utagawal you can just use an iframe (pretty much what the plugin is doing) like this

<iframe height="447" src="https://www.youtube.com/embed/JzS96auqau0?start=27" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

Remember that markdown is essentially html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants