Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The search page is not overridden #173

Open
lufog opened this issue Feb 23, 2019 · 1 comment
Open

The search page is not overridden #173

lufog opened this issue Feb 23, 2019 · 1 comment

Comments

@lufog
Copy link
Contributor

lufog commented Feb 23, 2019

Usually, plug-in pages can be overridden by copying them into the pages folder and editing. Which is quite convenient if the site is multilingual. But this plugin does not see the page from the pages folder.
@lufog
Copy link
Contributor Author

lufog commented Feb 23, 2019

Is it related to this #43?

@petira petira mentioned this issue May 3, 2020
Merged
rhukster pushed a commit that referenced this issue May 13, 2020
@petira
Default vs. custom simplesearch.md (#186)
2c939b9 
Made code modifications to create a custom page without having to include a simplesearch section in the header. If the custom page contains a template variable in the header, it takes precedence over the setting in the config file. When using the default page, the opposite behavior occurs, where the settings in the config file are preferred, which overrides the settings in the page header, assuming that the default page now contains the template variable directly from the plugin authors.

This fixes some of the issues described in #173 and #43 (maybe others too).

I will send other separate improvements in the next Pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lufog