Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox has extra padding because of invisible, duplicated label #441

Open
NicoHood opened this issue Sep 28, 2020 · 2 comments · May be fixed by #442
Open

Checkbox has extra padding because of invisible, duplicated label #441

NicoHood opened this issue Sep 28, 2020 · 2 comments · May be fixed by #442

Comments

@NicoHood
Copy link
Contributor

The current checkbox implementation has an invisible label which causes the form to add an ugly extra margin

grafik
grafik

The "real" label is placed right next to the input field, and thatswhy the normal label is not needed. In the code the label is cleared (empty block), but the div around will still be there.

I will upload a PR shortly that should be linked by github itself.
@NicoHood NicoHood linked a pull request Sep 28, 2020 that will close this issue
Open
NicoHood added a commit to NicoHood/grav-theme-quark that referenced this issue Oct 23, 2020
@NicoHood
Fixed checkbox label whitespace getgrav/grav-plugin-form#441
458d2ad
@SeriousKen
Copy link

This is definitely an issue for me too. I'm trying to write a plugin to integrate forms with Bootstrap 5 and I've pretty much had to rewrite the field layout template to hide the label if the label block is empty. It's worse with bootstrap as the label is 24px high even when empty.

@NicoHood
Copy link
Contributor Author

@SeriousKen You can also use display_label: false on each field as a workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checkbox label margin (remove empty label) NicoHood/grav-plugin-form
2 participants
@NicoHood @SeriousKen