Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate locked normals is buggy #183

Closed
BigRoy opened this issue Jun 12, 2017 · 5 comments
Closed

Validate locked normals is buggy #183

BigRoy opened this issue Jun 12, 2017 · 5 comments
Labels

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 12, 2017

Issue

The locked normal validation for meshes is currently not checking the full model if the transforms are in the instance as opposed to the shapes. The collector only includes the direct set members in the instance in Maya, as such if the ROOT group was in the instance, then none of its children are passed in the instance.

So history, children or parents are not included from the collect instance members.

Problem

This introduces the problem where a Validator does not have access to the full hierarchy by just using the nodes in the instance. It'll need to retrieve the history, children or parents whenever it needs to check them. Just like how maya.cmds.ls(instance, type="mesh") wouldn't actually return in the related meshes in the Validate Normals plugin.

Solution

The solution can be done in two ways:

  • Either the validator retrieves the data from the scene; it finds the history, parents, or children that it needs to check. For example also include: maya.cmds.listRelatives(instance, allDescendents=True, fullPath=True) or for history checks do maya.cmds.listHistory(instance).

Note: these calls to list history or children can be slow in large scenes.

  • Or the collector collects this additional data.
@mottosso mottosso added the bug label Jun 12, 2017
@mottosso
Copy link
Contributor

Thanks @BigRoy.

I've added you and @aardschok as collaborators to this repo so that you can tag your issues with relevant labels. It also enables you to push to this repo, but please don't do that. Only pull-requests are supposed to make modifications.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 12, 2017

I've added you and @aardschok as collaborators to this repo so that you can tag your issues with relevant labels.

Funnily enough I'm not able to edit any labels on issues.

@mottosso
Copy link
Contributor

mottosso commented Jun 12, 2017

I think you might have to accept the invite first.
https://github.com/mindbender-studio/core/invitations

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 12, 2017

I think you might have to accept the invite first.

Perfect; that was it. I missed that. I'm able to do so now.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 23, 2017

Closing this since plug-ins have been removed. Continuing here: mindbender-studio/config#3

@BigRoy BigRoy closed this as completed Jun 23, 2017
tokejepsen pushed a commit to tokejepsen/core that referenced this issue Oct 31, 2020
…ok_assigner_to_pype_menu

Added mayalookassigner to Pype menu in Maya
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants