Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fiat examples in README are wrong #128

Open
rolznz opened this issue Dec 19, 2023 · 1 comment
Open

fiat examples in README are wrong #128

rolznz opened this issue Dec 19, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rolznz
Copy link
Contributor

rolznz commented Dec 19, 2023

In the README it says getFiatValue(satoshi: number, currency: string): number but getFiatValue takes a single object as a parameter.

Can you check all the examples and update them?
@rolznz
Copy link
Contributor Author

rolznz commented Dec 19, 2023

CC @bumi

@rolznz rolznz added the good first issue Good for newcomers label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alan-AC7 @rolznz