-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated documentation site #159
Comments
there is an application known as Docsify where u can convert ur documentation into live website |
i could work on that |
@vr-varad awesome! Would we be able to somehow split the documentation for the bitcoin-connect and bitcoin-connect-react packages? and how will the examples be added to the documentation? I guess we will need to add some more documentation comments in the code, but it would be nice to see a minimal proof of concept of how it looks out of the box. |
ya sure |
https://bitcoin-connect-3s840lue0-varad-guptas-projects.vercel.app/#/ |
u can give it a look @rolznz |
@rolznz what are ur thoughts on this |
@vr-varad sorry, I cannot access the vercel link - it asks me to login. Can you make it public? |
https://bitcoin-connect-exp.vercel.app/#/ |
@vr-varad thanks, it works now. I like the sidebar, but it is still a huge long page of documentation. The goal here is to make simple documentation that is easy to follow - not a single large document like the README currently is. |
I am working on that only will let u know in an hour or two. |
https://bitcoin-connect-exp.vercel.app/#/ |
@vr-varad cool! Is this possible to run with github pages as a static site? do you think you could do a minimal fork of bitcoin connect with these changes so we don't need to host it on vercel? sections like https://bitcoin-connect-exp.vercel.app/#/./bitcoinConnectAPI/README are way too large - can they be split into subpages? The sections are not split very logically, but if we decide to go with this approach I can provide an exact list for you. I would also put the banner back on the home page, and maybe use a different image for the sidebar. And also, there seem to be some empty pages committed and the naming of the routes could be improved. I will try to get some feedback from the team. |
that would be good. |
@vr-varad did you also look at any other tools? what about docusaurus? from the comparison it has some advantages over docsify. https://docusaurus.io/docs#comparison-with-other-tools |
ya this looks better to me |
@vr-varad if you are happy to, that would be great! |
Maybe doing just a proof of concept would be simpler so it's easy to review - add a sidebar/navigation with just two or or three pages. Could you do this in a fork directly off https://github.com/getAlby/bitcoin-connect and make a pages workflow at the same time? |
sorry for being late @rolznz |
Hi @vr-varad can you please make sure you can run it on github pages, and then share the github link? There is no need to add a landing page since we already have one here: https://bitcoin-connect.com/ Also, the sidebar items are quite strange - why is "docs" in a separate section that has to be expanded? I would have items like:
|
Ok, no problem @rolznz I will work on that |
hey @rolznz |
Thanks @vr-varad - this is great! There are still some things to fix, but I can give you follow-up feedback for that. The reason I asked about github pages and a PR on bitcoin-connect directly is because we need to evaluate the amount of changes and whether this is something we can maintain long-term. So this is the most important thing right now. |
I can understand, it will be done by today. |
@rolznz I created the pr regarding the deploy folder plz check it out and leave a review. |
The README is very long and not very readable / developer friendly
Can a docusaurus documentation site be added to the github and the README contents moved there? it should be built as a github action.
The text was updated successfully, but these errors were encountered: