Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Name mismatch in query_direct_table_access docs #117

Open
kirk-dave opened this issue Jun 9, 2023 · 4 comments · May be fixed by #166
Open

Column Name mismatch in query_direct_table_access docs #117

kirk-dave opened this issue Jun 9, 2023 · 4 comments · May be fixed by #166

Comments

@kirk-dave
Copy link

In the query_direct_table_access model there is a mismatch between the docs and the model for table_name.

Happy to contribute a fix for this.


- name: table_name
description: Fully qualified table name, i.e. <database_name>.<schema_name>.<table_name>

@kirk-dave
Copy link
Author

If a fix is wanted, let me know what's preferred: table_name or full_table_name

@ian-whitestone
Copy link
Contributor

Thanks @kirkbrunson-dave! A PR would be amazing. Let's update the docs to align with what is already in the model.

Thanks again for flagging.

@kirk-dave
Copy link
Author

Great! @ian-whitestone Do I need to do anything to get set up as a contributor? Getting the following pushing the PR to a feature branch
Screen Shot 2023-06-09 at 4 40 44 PM

@ian-whitestone
Copy link
Contributor

@kirkbrunson-dave it looks like an issue with your git command

Once you have pushed your commit to your forked repo, you should be able to open a PR from the github UI https://jarv.is/notes/how-to-pull-request-fork-github/

@greg-finley greg-finley linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants