Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate empirical point-spread function (PSF) determination #405

Open
3 tasks
vreuter opened this issue Dec 19, 2024 · 0 comments
Open
3 tasks

Deprecate empirical point-spread function (PSF) determination #405

vreuter opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
configuration documentation Improvements or additions to documentation
Milestone

Comments

@vreuter
Copy link
Collaborator

vreuter commented Dec 19, 2024

It's pegged to use maximum likelihood estimation (MLE) rather than least-squares (LS), and we haven't used this in quite some time, so it's unclear how nicely it would play with all the other components and risks therefore to be buggy.

  • raise NotImplementedError in the function body
  • check up front in the pipeline precheck that the configuration doesn't specify to use the experimental PSF features, and if so, throw an error right away
  • update the documentation accordingly
@vreuter vreuter added documentation Improvements or additions to documentation configuration labels Dec 19, 2024
@vreuter vreuter self-assigned this Dec 19, 2024
@vreuter vreuter added this to the v0.13 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant