Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type for ImagingContext.fieldOfView #14

Open
vreuter opened this issue Nov 16, 2024 · 0 comments
Open

Type for ImagingContext.fieldOfView #14

vreuter opened this issue Nov 16, 2024 · 0 comments
Milestone

Comments

@vreuter
Copy link
Contributor

vreuter commented Nov 16, 2024

Right now, fieldOfView is typed as FieldOfViewLike, which is equal to PositionName | FieldOfView. Either...
a) one of these types should be removed
b) ImagingContext should carry a type parameter like FOV <: PositionName | FieldOfView which would then be the type of the fieldOfView member, to disambiguate.

This has consequences for any type which uses ImagingContext, but it would make things like defining Order[ImagingContext] more reasonable; currently, this would need to be a partial function, since there's no real meaningful way to order a PositionName (text) value relative to a FieldOfView value (number).

@vreuter vreuter changed the title ImagingContext.fieldOfView type Type for ImagingContext.fieldOfView Nov 16, 2024
@vreuter vreuter added this to the v0.4 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant