Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vendor-option graphic-margin #971

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Nov 18, 2024

⚠️ Draft PR

For #969

I add here a first VendorOption with the graphic-margin property. This is linked to the
additional Geostyler-styler GraphicFillPadding property: geostyler/geostyler-style#651

ToDo:

  • Clarify questions
  • Add tests
  • Fix Fixmes

As It's the first VendorOption, I've several questions:

  1. Is the code looking as expected ?
  2. Can I add tests directly into src/SldStyleParser.geoserver.spec.ts ? Or should I had a dedicated test file ?
  3. How can we add this new withVendorOption parameter into the Geostyler demo, cli or qgisparser ? Shopuld I create and issue about that ("be more flexible with parser options") ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant