Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparision Filter PropertyIsLike #901

Open
rajsync opened this issue Nov 27, 2023 · 5 comments
Open

Comparision Filter PropertyIsLike #901

rajsync opened this issue Nov 27, 2023 · 5 comments

Comments

@rajsync
Copy link

rajsync commented Nov 27, 2023

Feature Request

Is your feature request related to a problem? Please describe.
currently wildcard, singleChar and escape values are hard coded.

Describe the solution you'd like
option to pass wildcard, singleChar and escape values, while creating comparison filter PropertyIsLike

@jansule
Copy link
Contributor

jansule commented Dec 1, 2023

Good point. To do so, we would have to add these options to the typing for the propertyIsLike filter in the geostyler-style here and here (the *= is the equivalent of propertyIsLike). Then, the sld-parser could be adjusted to that.

Are you planning on providing a PR for this?

@rajsync
Copy link
Author

rajsync commented Dec 7, 2023

I have made changes to provide "PropertyIsLike" attributes. Please check the pull request geostyler/geostyler-style#616.

@rajsync
Copy link
Author

rajsync commented Dec 7, 2023

I have to make changes to "geostyler-sld-parser" project to remove use the provided like attributes. After the pull request complete and released?

@jansule
Copy link
Contributor

jansule commented Jan 2, 2024

You can also develop based on your unmerged changes by using npm link. Please reference the open PR in the description, then.

@KaiVolland
Copy link
Contributor

Hey @rajsync do you think you will continue working on the PR in the geostyler-style? Otherwise we might could take care of it in the upcoming codesprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants