Skip to content
This repository has been archived by the owner on Nov 30, 2017. It is now read-only.

Make GUI files reusable in customized GeoBatch modules #197

Open
etj opened this issue Jun 27, 2013 · 4 comments
Open

Make GUI files reusable in customized GeoBatch modules #197

etj opened this issue Jun 27, 2013 · 4 comments

Comments

@etj
Copy link
Member

etj commented Jun 27, 2013

At the moment, when creating a custom GB build, the src/webapp files have to be copied manually in the new module. We need a way to automatically import the original files from geobatch web app module.

@etj
Copy link
Member Author

etj commented Jun 27, 2013

The idea is to use maven overlays, and then split the main geobatch .war in two:

  • a core .war, only containing GUI related files to be shared with customized geobatch modules
  • a final .war, adding the core .war as overlay and using all the existing related dependencies

@etj
Copy link
Member Author

etj commented Jun 27, 2013

In src/gui there are only the MVC controllers. Would be a good idea to merge this stuff into the core GUI module.

@etj
Copy link
Member Author

etj commented Jul 1, 2013

Changes committed in this branch: https://github.com/geosolutions-it/geobatch/tree/issue197-web-core-refactor
Please test.

@etj
Copy link
Member Author

etj commented Aug 21, 2013

Some new work on https://github.com/geosolutions-it/geobatch/tree/issue197-web-core-refactor-2, rebased on current master.

Now the produced WAR should be fine, the webapp can be run with

   mvn jetty:run-exploded

and can be run using Start.java both from NB and Eclipse.

Since running Start.java was loading the required libs both from WEB-INF/lib and from the mvn classpath, creating so dup issues, a new ClassLoader has been implemented that skips libs from WEB-INF.

Please note that while NB loads dependant libs from .m2/repository, Eclipse may use the files in the target/ directory of depending projects if they are in the current working set. The implemented solution should work in both cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant