-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation is a bit unclear #34
Comments
The meanings of clockwise, counterclockwise, and positive are assumed to be in keeping with the original paper and documentation coordinate system (section 4.1):
|
Well, yes, but the paper doesn't seem to be very clear about that either. |
In that case I suggest you direct your questions to Jonathan Shewchuk. |
Suppose I found out, would you be open to change the documentation? Because that's what this is ultimately about. |
Yes, we're always open to clearer documentation. |
The documentation for
incircle
,orient2d
andorient3d
all speak of "counterclockwise order", but without specifying the assumed handedness of the coordinate system, this is fairly meaningless.The documentation for
insphere
speaks of the points needing to be in a "positive orientation". It is unclear what is meant by this. I'm also not sure if this is in any way intuitively quantifyable? Perhaps something along the lines of: a positive orientation is where point d is on the left or right (whichever is applicable, handedness applies here as well) of the plane defined by the triangle abc. I'm not sure whether this definition always holds, though.The text was updated successfully, but these errors were encountered: