Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geOrchestra overlay details #713

Open
Gaetanbrl opened this issue Aug 1, 2024 · 17 comments
Open

geOrchestra overlay details #713

Gaetanbrl opened this issue Aug 1, 2024 · 17 comments

Comments

@Gaetanbrl
Copy link
Contributor

Description

It would be usefull to identify the special georchestra's features that overlay basic mapstore2 project.

Some examples :

  • dedicated plugins
  • authentication items or bridge to works with mapstore2
  • header
  • theme
  • ?

I invite the community to add their knowledge to this issue via comments.

The final objective is to create a doc / have a trace (and why not a guide to be able to upgrade Mapstore2 submodule freely).

@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Aug 1, 2024

@Gaetanbrl
Copy link
Contributor Author

Some customization was located in /js directory (e.g plugins) :

https://github.com/georchestra/mapstore2-georchestra/tree/master/js

@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Aug 1, 2024

Here, a custom configuration to insert / use easyTheming plugin (not exists in nativ mapstore2) :

6ba8f3b

@Gaetanbrl
Copy link
Contributor Author

@f-necas what about custom docker (or other build stuff) config / files / build ?

@f-necas
Copy link
Contributor

f-necas commented Aug 1, 2024

@f-necas what about custom docker (or other build stuff) config / files / build ?

We override server.xml but there's a PR upstream for that, as far as I know, not a lot of customization around docker .

@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Aug 1, 2024

  • About authent / Login, a plugins seems bridge georchestra authent <-> mapstore authent system :

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Login.jsx

  • About usersession management, same in /js directory

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/UserSession.jsx

  • About mapping header with mapstore

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Header.jsx

  • Not allowed plugin (i don't really know what's this)

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/NotAllowed.jsx

  • A component to show versions (maptore2-georchestra and submodule)

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Version.jsx

  • A plugin to ease default mapstore2 theme customization without any build action

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/EasyTheming.jsx

(see this commit to understand)

  • Usersession plugin that override of the standard UserSession plugin to get more informations

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/UserSession.jsx#L12
https://github.com/georchestra/mapstore2-georchestra/blob/master/js/epics/usersession.js#L67

@landryb
Copy link
Member

landryb commented Aug 1, 2024

@Gaetanbrl
Copy link
Contributor Author

mapstore-georchestra use some Custom pages :

https://github.com/georchestra/mapstore2-georchestra/tree/master/js/pages

2 pages exists in mapstore2-georchestra :

  • Admin
  • ContextCreator

I need to understand correctly what this pages do.

@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Aug 1, 2024

Ok pages are used by application router (e.g mapstore/#/admin):

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L25

name: "admin",
path: "/admin",
component: Admin

@landryb
Copy link
Member

landryb commented Aug 1, 2024

it's probably specific to georchestra, because a default mapstore has the context manager on /#/context-manager ?

@MaelREBOUX MaelREBOUX changed the title Georchetra overlay geOrchestra overlay details Aug 1, 2024
@Gaetanbrl
Copy link
Contributor Author

@landryb /admin page was added from #37

@catmorales
Copy link
Collaborator

I don't see if you spoke about the use of SP headers

@catmorales
Copy link
Collaborator

Sorry I saw in #713 (comment)

@Gaetanbrl
Copy link
Contributor Author

it's probably specific to georchestra, because a default mapstore has the context manager on /#/context-manager ?

This is correct @landryb.

After some tests to reproduce /admin page in mapstore2, and as I understand it, this is how it seems works.

  • Create a custom page

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/pages/Admin.jsx

  • Config mapstore router to user this custom /admin page from Admin component

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L99-L101

  • Config this page from plugin's configs/localConfig.json section

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L99-L101

This config will specify the /admin page content.
The default geOrchestra's localConfig.json file specify to use Header, omnibar, Login and context-manager inside.

Note that localConfig doesn't content ContextManager plugin (replace by Admin I guess).
Note that ContextManager is maybe (not sur) override by custom ContextCreator page.

@catmorales
Copy link
Collaborator

catmorales commented Aug 5, 2024

Note that localConfig doesn't content ContextManager plugin (replace by Admin I guess).

But it's the aim of https://github.com/georchestra/mapstore2-georchestra/blob/master/configs/pluginsConfig.json

@Gaetanbrl
Copy link
Contributor Author

About Project and mapstore2 submodule update / migration :
https://training.mapstore.geosolutionsgroup.com/project/introduction/index.html#mapstore2-submodule-update

@Gaetanbrl
Copy link
Contributor Author

In best practice part :

The list above shows the most common checks but based on the complexity of the project customization we could have additional files to compare

We maybe needs some additional infos about these additional files to compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants