Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selection layer below parcel layer at first extension load #169

Closed
landryb opened this issue Aug 10, 2022 · 5 comments
Closed

selection layer below parcel layer at first extension load #169

landryb opened this issue Aug 10, 2022 · 5 comments
Assignees
@alexander-fedorenko
Labels
investigation

Comments

@landryb
Copy link
Member

landryb commented Aug 10, 2022

with v2.0.0-rc, i have a weird behaviour where the selection layer is below the plot layer, making it invisible if the selected plot is a building that covers the complete plot.

see animated gif below:
cadastrapp

closing/reopening the cadastrapp pane makes the selection layer go above the plot layer as expected.

i've tested it with a context configured with the plot layer (where i've witnessed #166, the plot layer is loaded twice in the map) or with cadastrapp being loaded in the default config (the gif was made in this config)

@catmorales ?
@landryb
Copy link
Member Author

landryb commented Aug 10, 2022 •
edited
Loading

can't reproduce the issue with 1.0.0-rc15 so probably a regression... wild guess, maybe c0e3237 ?

@landryb landryb mentioned this issue Aug 10, 2022
Open
@tdipisa
Copy link
Collaborator

tdipisa commented Aug 10, 2022

@landryb I will ask the team for a check. Thank you.

alexander-fedorenko added a commit to alexander-fedorenko/mapstore2-cadastrapp that referenced this issue Aug 30, 2022
@alexander-fedorenko
georchestra#169 Making sure that vector layer is initialized only aft…
01ff738 
…er raster layer
@alexander-fedorenko alexander-fedorenko mentioned this issue Aug 30, 2022
Merged
12 tasks
dsuren1 pushed a commit that referenced this issue Aug 31, 2022
@alexander-fedorenko
169 Adusting sequence of cadastrapp layers creation (#177)
4782ac5 
* #169 Making sure that vector layer is initialized only after raster layer

* Solving issue when initial load of layers does not get selections information from state.

* Updating dependencies to make project pass tests upon build.
See geosolutions-it/MapStore2@1ea2597

* Leftovers removal
@tdipisa
Copy link
Collaborator

tdipisa commented Aug 31, 2022 •
edited
Loading

@landryb we fixed this through #177. Please, see PR description if you need details. Feel free to close this issue if the fix works for you.

@landryb
Copy link
Member Author

landryb commented Aug 31, 2022

@landryb we fixed this through #177. Please, see PR description if you need details. Feel free to close this issue if the fix works for you.

thanks @alexander-fedorenko, i've tested #177 and can confirm that the selection layer is now correctly above parcel layer at first extension load.

@tdipisa if you can also merge/review #171 & #176 before cutting another rc that would be nice - thanks ! :)

@landryb landryb closed this as completed Aug 31, 2022
@tdipisa
Copy link
Collaborator

tdipisa commented Aug 31, 2022 •
edited
Loading

Thank you @landryb. Yes, I've assigned @dsuren1 as a reviewer for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fedorenko alexander-fedorenko

Labels
investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tdipisa @landryb @alexander-fedorenko