Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: add an env var for the private recaptcha key #76

Open
jeanpommier opened this issue Nov 30, 2023 · 3 comments
Open

console: add an env var for the private recaptcha key #76

jeanpommier opened this issue Nov 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeanpommier
Copy link
Member

No description provided.

@jeanpommier jeanpommier self-assigned this Nov 30, 2023
@jeanpommier
Copy link
Member Author

Maybe it's just about setting an extra_environment entry. To check

@edevosc2c edevosc2c added the enhancement New feature or request label Nov 30, 2023
@edevosc2c
Copy link
Member

edevosc2c commented Nov 30, 2023

the question is if we want to include that as an option into the helm chart or not?

because if it's the latter one, it's already possible:
set these helm values:

console:
  extra_environment:
    - name: RECAPTCHA_KEY
      value: "mykey"

then in console.properties:

privateKey=${RECAPTCHA_KEY}

Just my opinion, for me, I don't think this should be included in the helm chart. This is not a common parameter, and if we go that route then we may clutter the helm chart with the dozens of other "secret" parameters.

As a real example, for the gateway component we need to keep oauth credentials secret. I did set the credentials using the environment variable and I did set them as an environment inside security.yaml in the datadir for the gateway.

@jeanpommier
Copy link
Member Author

Yes, that's why I added the comment. I had forgotten about this possibility. I just need to check it works but there's no reason why. Please let me check and I'll close the ticket

Thanks for the extensive answer anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants