Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DATAHUB_HOST environment variable #67

Open
edevosc2c opened this issue Nov 8, 2023 · 0 comments
Open

remove DATAHUB_HOST environment variable #67

edevosc2c opened this issue Nov 8, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@edevosc2c
Copy link
Member

Datahub is not part of the helm georchestra, so the host env shouldn't be included in the helm chart:
https://github.com/georchestra/helm-georchestra/blob/main/templates/_helpers-envs.tpl#L25C9-L25C21

On top of that, it's hardcoding the fact that the service datahub would be called "datahub-datahub-svc" but it could very well be another name. If the helm release is called "datahub2" then the service name will be called "datahub2-datahub-svc"

As this environment variable has probably already been used somewhere in the datadir, we should be careful of this removal.

@edevosc2c edevosc2c added the enhancement New feature or request label Nov 8, 2023
@edevosc2c edevosc2c self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant