Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically build docker image for a pull request #44

Open
edevosc2c opened this issue Jun 22, 2023 · 3 comments
Open

automatically build docker image for a pull request #44

edevosc2c opened this issue Jun 22, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@edevosc2c
Copy link
Member

for development purposes, it would be easier to automatically build a docker image when a pull request is created.

use github actions for that

@edevosc2c edevosc2c added the enhancement New feature or request label Jun 22, 2023
@edevosc2c edevosc2c self-assigned this Jun 22, 2023
@fvanderbiest
Copy link
Member

Agreed ! Thanks :-)

@groldan
Copy link
Member

groldan commented Nov 4, 2023

Do you mean to build the image and also push it to dockerhub for each pull request?
I disagree, won't we end up with a ton of images on dockerhub. Is that standard practice? I've seen it on private registries, but not sure about abusing the dockerhub repo that much. Unless we can also remove the image once the PR is merged/closed?

@edevosc2c
Copy link
Member Author

Yes pushing to a docker repository.
You can set expiration on dockerhub. That would help in not abusing the platform too much.

@edevosc2c edevosc2c reopened this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants