Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: fixes to OGC API query form and redundant requests #892

Merged
merged 4 commits into from
May 29, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented May 29, 2024

Description

This PR fixes the following issues with the OGC API integration in the Datahub:

  • Redundant parallel requests will now be merged, reducing the amount of requests by around 75%
  • OGC API links pointing to a collection of type "record" will now work (previously they were crashing)
  • Removed an error that was happening when opening the API query form (the query URL was computed before the endpoint object was ready)

This PR upgrades ogc-client to the latest version to benefit from camptocamp/ogc-client#45 and camptocamp/ogc-client#46.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

github-actions bot commented May 29, 2024

Affected libs: feature-dataviz, feature-record, feature-router, ui-elements, feature-notifications, feature-catalog, feature-editor, feature-search, feature-map, ui-catalog, ui-search, data-access-datafeeder, api-metadata-converter, api-repository, feature-auth, util-data-fetcher, util-app-config, common-fixtures, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, data-access-gn4, common-domain, ui-dataviz, util-i18n,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented May 29, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented May 29, 2024

Coverage Status

coverage: 83.882% (-0.4%) from 84.26%
when pulling 3d43e11 on update-ogc-client-parallel-requests
into 16f429a on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this one @jahow ! It works really well and is really fast 🤩

@jahow jahow force-pushed the update-ogc-client-parallel-requests branch from 0a73722 to dd2eeaa Compare May 29, 2024 15:33
@jahow jahow force-pushed the update-ogc-client-parallel-requests branch from dd2eeaa to 3d43e11 Compare May 29, 2024 15:34
@jahow jahow merged commit 431347d into main May 29, 2024
9 checks passed
@jahow jahow deleted the update-ogc-client-parallel-requests branch May 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants