-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEL - datahub - tile WMS #887
Conversation
7825a11
to
7b105be
Compare
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Haven't tested but it looks good. We have to keep in mind to 1/ document the setting here and 2/ make sure that the next version will mention this change (exp. the gutter being gone) and let people know that they might need to use this setting if they have artefacts close to tile borders.
7b105be
to
5e97027
Compare
0bf131b
to
749a57d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rcaplier, tested it and it works fine! Geowebcache now responds with a Geowebcache-Cache-Result: HIT
when keeping the default behavior (WMS being tiled) 🙂
6653367
to
f0ae0ef
Compare
Thanks for the adaptions @rcaplier! I think this one can be merged once the conflict is resolved. Watch out rebasing, there's a new |
…iled or not. False by default.
f0ae0ef
to
7c8f48d
Compare
Description
This PR introduces a new parameter in the default.toml config file:
do_not_tile_wms
which is false by default.Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.