Button type directly in class

[f-necas]

Fix buttons not using their tailwind classes.

[github-actions]

Affected libs: ui-inputs, feature-dataviz, feature-record, feature-router, feature-editor, feature-search, feature-map, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

• 🚀 Build and deploy storybook and demo on GitHub Pages
• 📦 Build and push affected docker images

[fgravin]

I don't really see the meaning of this change, it complexifies the button api.
Couldn't you adopt another approach ?

[f-necas]

@fgravin It's not really a big change, instead of primary we would have to write btn-primary.

It's just a small step to fix the display of not secondary buttons.

It's intended to get rid of this gn-ui-button either which will result in a <button type="button" class="btn-primary>"

But I couldn't really understand why in the get classList inside button component couldn't handle correctly btn-${type} but can handle ${type}

[jahow]

Wait, how come this fixes the issue? edit: sorry, just saw the above messages. I think if we're going to modify every gn-ui-button usage then we might as well use the opportunity to get rid of this component altogether? But I would be very interested to know the underlying reason for this problem.

[jahow]

Thanks!