Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish NPM package on every commit on main branch #758

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Jan 10, 2024

This should also publish the package on every release, as well as attempt a build of the npm package on every PR to make sure that it doesn't break.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Affected libs: ui-catalog, feature-catalog, feature-record, feature-router, ui-elements, feature-search, feature-map, feature-dataviz, ui-search, ui-inputs, feature-editor,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jan 10, 2024

Coverage Status

coverage: 82.276% (-17.7%) from 100.0%
when pulling d433250 on auto-publish-npm-package
into f89e411 on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would test the artifact actions via a PR comment though, to be sure that it works as expected.

@jahow jahow force-pushed the auto-publish-npm-package branch 11 times, most recently from 1406362 to 9b49677 Compare January 10, 2024 21:13
@jahow jahow force-pushed the auto-publish-npm-package branch from 9b49677 to d433250 Compare January 10, 2024 21:18
@jahow jahow merged commit 0f95f70 into main Jan 10, 2024
7 of 8 checks passed
@jahow jahow deleted the auto-publish-npm-package branch January 10, 2024 21:22
Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you erase the commit i've pushed yesterday about the universal thing ?

@jahow
Copy link
Collaborator Author

jahow commented Jan 11, 2024

Do you erase the commit i've pushed yesterday about the universal thing ?

oh yes sorry I forced push without pulling first, I'll readd it

@jahow
Copy link
Collaborator Author

jahow commented Jan 11, 2024

Readded here: #760
with also updated dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants