Add contact block to news page and improve buttons #747
Conversation
|
Affected libs:
|
There was a problem hiding this comment.
Great work! I like the refactor of the button logic! Thanks @f-necas
| @@ -132,9 +132,6 @@ describe('DownloadsListComponent', () => { | |||
| LINK_FIXTURES.geodataShpWithMimeType | |||
| ) | |||
| expect(items[0].componentInstance.format).toEqual('shp') | |||
| expect(items[0].componentInstance.color).toEqual( | |||
There was a problem hiding this comment.
Is this change necessary in this PR? I'm just wondering why this got removed.
There was a problem hiding this comment.
It is because the color getter is deleted. So we can't call it anymore : https://github.com/geonetwork/geonetwork-ui/pull/747/files#diff-5cfed937e30ec743c98e5e024350945ee6d4d0b6e7e34dabac9f3fb580fa0ad4L27-L28
There was a problem hiding this comment.
that shouldn't be impacted here, unless I'm missing something; in general we should strive to avoid reducing the test coverage :)
There was a problem hiding this comment.
Oh yeah indeed, I don't know why my IDE displayed it in red. Sry @Angi-Kinas for the misunderstood !
| <h2 | ||
| class="text-2xl font-title text-primary leading-7 text-left" | ||
| translate | ||
| > | ||
| datahub.news.contact.title | ||
| </h2> | ||
| <p translate>datahub.news.contact.desc1</p> | ||
| <p translate>datahub.news.contact.desc2</p> |
There was a problem hiding this comment.
Note that you can here simply use a translation key that accepts HTML, see for instance https://github.com/geonetwork/geonetwork-ui/blob/main/translations/en.json#L112
instead of hardcoding a structure with a title and paragraphs
conf/default.toml
Outdated
| @@ -34,6 +34,9 @@ proxy_path = "" | |||
| # More information about the translation can be found in the docs (https://geonetwork.github.io/geonetwork-ui/main/docs/reference/i18n.html) | |||
| # languages = ['en', 'fr', 'de'] | |||
|
|
|||
| # Allows displaying a contact email on news page for missing data | |||
There was a problem hiding this comment.
| # Allows displaying a contact email on news page for missing data | |
| # Enables displaying a "contact block" wherever relevant in applications |
f-necas
force-pushed
the
DH/add-contact-to-news-page
branch
2 times, most recently
from
67995b7 to
a2973a5
Compare
f-necas
force-pushed
the
DH/add-contact-to-news-page
branch
from
63e40b7 to
7e28879
Compare
Contact block & buttons
Contact
Add a contact block with a configurable mail in
default.tomlHow-to
Add mail in
default.tomlButtons improvement
As
gn-ui-buttonisn't really necessary, this PR also propose to improve them with tailwind classes intailwind.base.css.This is the first (without breaking changes) step to get rid of
gn-ui-button.